rootless: do not raise an error if the entrypoint is specified #1472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
do not error out when the storage is not initialized and the entrypoint command is not available for the specified image. Check it when we re-exec in an user namespace and can access the storage. Closes: containers#1452 Signed-off-by: Giuseppe Scrivano <[email protected]>
|
LGTM |
|
bot, retest this please |
|
LGTM |
|
I'll give CI a bit to see that we're really back before starting homu |
|
📌 Commit 1c26d81 has been approved by |
|
⌛ Testing commit 1c26d81 with merge 00ac67d... |
|
💔 Test failed - status-papr |
|
@rh-atomic-bot retry |
|
bot, retest this please |
|
⌛ Testing commit 1c26d81 with merge ede18bd... |
|
💔 Test failed - status-papr |
|
@rh-atomic-bot retry |
|
bot, retest this please |
|
⌛ Testing commit 1c26d81 with merge 285abce... |
|
💔 Test failed - status-papr |
|
Rootless rootfs flaked |
|
⌛ Testing commit 1c26d81 with merge d660d6f... |
|
bot, retest this please |
|
I think we're actually good to merge this manually |
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
do not error out when the storage is not initialized and the
entrypoint command is not available for the specified image. Check it
when we re-exec in an user namespace and can access the storage.
Closes: #1452
Signed-off-by: Giuseppe Scrivano [email protected]